This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Signature support #41
Open
zabolotiny
wants to merge
8
commits into
derekblair:master
Choose a base branch
from
zabolotiny:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, This is very useful, can you please resolve the conflicts and merge to master? Many thanks. |
@starcub Working on it, thanks. |
Hi, is there any progress on that? Thanks and regards Thomas |
I am very interested in the Signature support as well. Code looks great! Thanks, |
Hello @derekblair @sheff1422 this would be great to have. Could you look into solving conflicts and merging this in? |
Any update on an ETA for this? |
# Conflicts: # ILPDFKit/Controller/ILPDFViewController.m # ILPDFKit/ILPDFKit.h # ILPDFKitExample/ILPDFKitExample.xcodeproj/project.pbxproj # ILPDFKitExample/Pods/Local Podspecs/ILPDFKit.podspec.json # ILPDFKitExample/Pods/Pods.xcodeproj/project.pbxproj # ILPDFKitTests/Pods/Nimble/Sources/Nimble/Adapters/ObjectiveC/DSL.h # ILPDFKitTests/Pods/Nimble/Sources/Nimble/Adapters/ObjectiveC/NMBExceptionCapture.h # ILPDFKitTests/Pods/Nimble/Sources/Nimble/Adapters/ObjectiveC/NMBExpectation.swift # ILPDFKitTests/Pods/Quick/Sources/Quick/NSString+QCKSelectorName.h # ILPDFKitTests/Pods/Quick/Sources/Quick/NSString+QCKSelectorName.m # ILPDFKitTests/Pods/Quick/Sources/Quick/String+FileName.swift
@derekblair conflicts were resolved |
Hi there, is there any update on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Pal,
Signature support was implemented, would you be so kind to check that out. http://prntscr.com/cc9bwj
http://prntscr.com/cc9c1f
Please note that i can't update PodSpec file to support xib.
Also i have used another test pdf form.