Require folder destination for receiver downloads over 7GB#12
Open
derekShaheen wants to merge 3 commits into
Open
Require folder destination for receiver downloads over 7GB#12derekShaheen wants to merge 3 commits into
derekShaheen wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Choose folderbutton and contextual helper text inpublic/pages/receiver.htmlto surface folder-based download options to the receiver.public/assets/scripts/receiver.jsusing the File System Access API (showDirectoryPicker,getFileHandle,createWritable) and astreamWriterpath to write incoming binary chunks directly to disk.LARGE_TRANSFER_THRESHOLD = 7 * 1024 * 1024 * 1024andLARGE_FILE_THRESHOLD = 8 * 1024 * 1024 * 1024and enforced that if selected total bytes >7GBthe receiver must choose a folder before starting, while recommending folder use when any single file >8GB.Blob+ Save-link flow for unsupported browsers or smaller transfers and added UI updates viaupdateFolderUi()and selection handlers to reflect folder state.Testing
node --check public/assets/scripts/receiver.jsand it completed successfully.node --check server.jsand it completed successfully.npm startand verified the server listens onhttp://0.0.0.0:3000(startup succeeded).http://127.0.0.1:3000/receiver.htmlto validate UI render (screenshot saved as an artifact).Codex Task