fix: removed required columns validation for uploaded sample sheet validations#661
Merged
ignacionistal merged 1 commit intodevelopmentfrom Mar 6, 2026
Merged
Conversation
juanarroqui
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: removed required columns validation for uploaded sample sheet validations
Type of Change*
Description
Removed validation for required columns from sample sheet validation file to allow user to upload custom sample sheet with any structure. We only validate now that samplesheet is not empty, it's a valid csv file and it contains at least a header row.
Testing*
Tested manually on local and development environments.
Impact
Only impacts new feature for uploading custom sample sheet.
Additional Information
This was requested by client who specified that the sample sheets can have any format and columns. Client mentioned that validating it is not empty and a valid csv are the only requirements.
Checklist*