Skip to content

fix: removed required columns validation for uploaded sample sheet validations#661

Merged
ignacionistal merged 1 commit intodevelopmentfrom
fix/upload-sample-sheet-validations
Mar 6, 2026
Merged

fix: removed required columns validation for uploaded sample sheet validations#661
ignacionistal merged 1 commit intodevelopmentfrom
fix/upload-sample-sheet-validations

Conversation

@ignacionistal
Copy link
Contributor

fix: removed required columns validation for uploaded sample sheet validations

Type of Change*

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Removed validation for required columns from sample sheet validation file to allow user to upload custom sample sheet with any structure. We only validate now that samplesheet is not empty, it's a valid csv file and it contains at least a header row.

Testing*

Tested manually on local and development environments.

Impact

Only impacts new feature for uploading custom sample sheet.

Additional Information

This was requested by client who specified that the sample sheets can have any format and columns. Client mentioned that validating it is not empty and a valid csv are the only requirements.

Checklist*

  • No new errors or warnings have been introduced.
  • All tests pass successfully and new tests added as necessary.
  • Documentation has been updated accordingly.
  • Code adheres to the coding and style guidelines of the project.
  • Code has been commented in particularly hard-to-understand areas.

@juanarroqui juanarroqui self-assigned this Mar 5, 2026
@ignacionistal ignacionistal merged commit f737f20 into development Mar 6, 2026
1 check passed
@ignacionistal ignacionistal deleted the fix/upload-sample-sheet-validations branch March 6, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants