fix: Dev 환경 쿠키 이슈 해결 및 관련 로직 개선 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char-yb
reviewed
Feb 6, 2024
There was a problem hiding this comment.
NoArgsConstructor를 사용했을 때는 문제가 발생될까용?
There was a problem hiding this comment.
해당 어노테이션 사용해도 상관없습니다. 수정할게요
Comment on lines
22
to
37
|
|
||
| ResponseCookie accessTokenCookie = | ||
| ResponseCookie.from(ACCESS_TOKEN_COOKIE_NAME, accessToken) | ||
| .path("/") | ||
| .secure(true) | ||
| .secure(isSecured) | ||
| .sameSite(sameSite) | ||
| .httpOnly(false) | ||
| .httpOnly(true) | ||
| .build(); | ||
|
|
||
| ResponseCookie refreshTokenCookie = | ||
| ResponseCookie.from(REFRESH_TOKEN_COOKIE_NAME, refreshToken) | ||
| .path("/") | ||
| .secure(true) | ||
| .secure(isSecured) | ||
| .sameSite(sameSite) | ||
| .httpOnly(false) | ||
| .httpOnly(true) | ||
| .build(); |
There was a problem hiding this comment.
httpOnly를 true로 했을 때 발생되는 이벤트 한번 설명부탁드려도 될까용??
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
EnviromentConstants를 enum에서 일반 상수 문자열의 묶음 클래스로 변경했습니다.enum.values()등을 사용할 일이 없기 때문에 제거 후 대체했습니다.SpringEnvironmentUtil구현을 변경했습니다.isXXXProfile()메서드의 경우 원시형 boolean을 리턴하도록 개선했습니다.SameSite정책으로 인한 이슈를 해결했습니다.secure가true이면SameSite: None을 사용할 수 있습니다. 해당 사항을 반영했습니다.Allow-Origin이 와일드카드인 경우setAllowCredentials(true)가 작동하지 않습니다 (중요).Authorization헤더가 존재하는 요청을 처리할 수 없습니다.📝 참고사항
📚 기타