[TMN-58] 회원가입 후 온보딩 #642
Merged
[TMN-58] 회원가입 후 온보딩 #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sumi-0011
approved these changes
Mar 28, 2024
| }, | ||
| ]; | ||
|
|
||
| export const RECOMMENDATION_REAL = [ |
There was a problem hiding this comment.
process.env.node_env 애 떠러 REAL을 보여줄지 말지 컨트롤 하는건 어떨까요
There was a problem hiding this comment.
node_env 인 dev 배포환경일때는 'production'으로 보이지 않나요?
There was a problem hiding this comment.
NEXT_PUBLIC_ENV 라는 환경변수를 따로 만들게요
There was a problem hiding this comment.
| }; | ||
|
|
||
| const handleComplete = async () => { | ||
| await Promise.all( |
src/app/onboarding/page.tsx
Outdated
Comment on lines
73
to
77
| key={props.id.toString()} | ||
| id={props.id} | ||
| tags={props.tags} | ||
| nickname={props.nickname} | ||
| profileImageUrl={props.profileImageUrl} |
| rightComponent?: React.ReactNode; | ||
| } | ||
|
|
||
| function CenterTextHeader({ title, rightComponent }: CenterTextHeaderProps) { |
There was a problem hiding this comment.
일단 임시로 사용하는 Header인거죠?
나중에도 사용하게 된다면 디자인 시스템에 추가하면 좋을 것 같네요
There was a problem hiding this comment.
네 빠르게 작업하기 위해서 추가한 컴포넌트입니다
| width: '33%', | ||
| }); | ||
|
|
||
| const centerCss = css({ |
There was a problem hiding this comment.
css 대신 center pattern 이용해도 좋을 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
https://tenminute.atlassian.net/browse/TMN-36?atlOrigin=eyJpIjoiODg4MWI5Zjk2NTQ3NDA0MjkwNzcxMjU0MGFhOTljMWYiLCJwIjoiaiJ9
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
사용 방법
🌄 스크린샷
2024-03-27.12.10.48.mov
📚 참고