[Feat] event logging 추가 #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wade3420
requested review from
woobottle,
JUNOSHON and
sumi-0011
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
woobottle
reviewed
Feb 9, 2024
| onSuccess: () => { | ||
| onSuccess: (data) => { | ||
| if (data?.memberId) { | ||
| eventLogger.identify(data.memberId.toString()); |
There was a problem hiding this comment.
memberId가 nullable로 되어 있어서 이곳에 nullable 처리는 필요없을지 궁금해요~
There was a problem hiding this comment.
같은파일 97번쨰 줄 아래에 추가된 부분도 같은 이유로 궁금합니다
There was a problem hiding this comment.
nullable 처리한 건 서버에서 null 로 명시적으로 내려주는게 아니라
현재상황 (accessToken , refreshToken 만내려옴)상황을 에러없이 대응하려고 했습니다 (undefined 인경우)
서버에서 상용서버에 배포해주시면 memberId가 없이 내려오는 경우는 없을 것라 생각되요!
woobottle
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
event logging 추가
🎉 변경 사항
바텀 앱바 클릭 : 'click/tab'
결과 페이지 레벨 가이드 버튼 : 'click/levelGuide'
레벨 페이지 레벨 아이콘 클릭 :'click/level'
마이페이지 수정 버튼 : 'click/edit'
마이페이지 세팅 버튼 : 'click/setting'
마이페이지 레벨 배너 버튼 : 'click/levelBanner'
마이페이지 팔로우 리스트 버튼 : 'click/followFollow'
팔로우 프로필 팔로우 버튼 : 'click/followButton'
팔로우 리스트 팔로우 버튼 : 'click/followButton'
더 추가했으면 좋겠는 부분 알려주시면 추가하겠습니다.
🙏 여기는 꼭 봐주세요!
서버에서 memberId를 받기로 했습니다
관련 슬랙 : https://depromeet14th.slack.com/archives/C06C1271G56/p1707413630609489
사용 방법
🌄 스크린샷
📚 참고