[Feat] 팔로잉/팔로워 리스트 페이지 #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wade3420
reviewed
Feb 8, 2024
|
|
||
| export const sorFollowerList = (list: FollowerMemberWithStatusType[], myId: number): FollowerMemberWithStatusType[] => { | ||
| // 1순위) 내 계정, 내가 팔로잉 중인 계정, 내가 팔로우 중이지 않은 계정 순으로 리스트 나열 | ||
| // 2순위) 가나다 순, ABC순으로 나열 |
wade3420
reviewed
Feb 8, 2024
| }} | ||
| /> | ||
| {/* 내 팔로잉/팔로우 */} | ||
| {isMyself && |
There was a problem hiding this comment.
마이너 ) 주석을 없애고 isMyself 변수명을 좀더 명확하게 가져가면 좋겠음 isFollowMyself ? 정도?
There was a problem hiding this comment.
isMySelf라는 네이밍 자체를 잘못 지었나 싶네요 🤔
여기서 isMySelf는 자신의 프로필 팔로워/팔로잉 리스트인지 확인하는 변수입니다.
그래서 isFollowMyself 라는 네이밍은 맞지 않는 것 같아요..
어떻게 네이밍을 바꾸면 좋을까요.. 고민되네요
There was a problem hiding this comment.
마이너하니 다음에 생각하시죠. 한글 변수명은 어떠신가요
wade3420
approved these changes
Feb 8, 2024
배포 후 확인해달고 말해볼게요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
팔로잉/팔로워 리스트 페이지를 구현하였어요.
closed #483
🎉 변경 사항