[Fix] Stopwatch bug fix and useMutatuinHandleErorr hook 추가 #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # src/apis/record.ts
wade3420
reviewed
Feb 5, 2024
Comment on lines
84
to
89
| onError: (error: any) => { | ||
| if (error.response.data.data.errorClassName === 'MISSION_RECORD_ALREADY_EXISTS_TODAY') { | ||
| removeProgressMissionData(); | ||
| router.replace(ROUTER.HOME); | ||
| } | ||
| }, |
There was a problem hiding this comment.
isSeverError util 을 쓰면 sever 데이터 타입 추론되게 할 수 있을 것 같아요
(eslint-disable-next-line @typescript-eslint/no-explicit-any 사용하지 않을 수 있음)
Suggested change
| onError: (error: any) => { | |
| if (error.response.data.data.errorClassName === 'MISSION_RECORD_ALREADY_EXISTS_TODAY') { | |
| removeProgressMissionData(); | |
| router.replace(ROUTER.HOME); | |
| } | |
| }, | |
| onError: (error) => { | |
| if(!isSeverError(error)) { | |
| return | |
| } | |
| if (error.response.data.data.errorClassName === 'MISSION_RECORD_ALREADY_EXISTS_TODAY') { | |
| removeProgressMissionData(); | |
| router.replace(ROUTER.HOME); | |
| } | |
| }, |
wade3420
reviewed
Feb 5, 2024
| import { useSnackBar } from '@/components/SnackBar/SnackBarProvider'; | ||
| import { useMutation, type UseMutationOptions } from '@tanstack/react-query'; | ||
|
|
||
| interface SnackBarOptions { |
There was a problem hiding this comment.
마이너) 실제 스넥바의 interface와 같이 연결되면 좋을것 같아서 triggerSnackBar 의 argment 타입인 SnackBarWithoutId 라눈 타입에서 Omit 이나 Pick 을 이용해서 사용하면 좋을 것 같아요
wade3420
reviewed
Feb 5, 2024
| const { triggerSnackBar } = useSnackBar(); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const triggerServerErrorSnackBar = (error: any) => { |
There was a problem hiding this comment.
여기 error 에 any 타입선언이 안필요하다고 생각되는데 꼭 필요한 걸까요?
wade3420
reviewed
Feb 5, 2024
| } | ||
|
|
||
| function useMutationHandleError<T, _unknown, V>( | ||
| options?: UseMutationOptions<T, unknown, V>, |
wade3420
approved these changes
Feb 5, 2024
# Conflicts: # src/app/search/page.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?