[FEAT] 이전 달의 미션 캘린더 정보를 볼 수 있다. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wade3420
requested review from
woobottle,
JUNOSHON and
sumi-0011
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sumi-0011
approved these changes
Feb 5, 2024
src/hooks/useCalendar.ts
Outdated
Comment on lines
12
to
14
| const { queryParams, setQueryParams } = useQueryParams({ queryKey: 'date' }); | ||
| const [date, setDate] = useState(queryParams ? dayjs(queryParams) : currentData); | ||
| const { monthCalendarData } = getCalenderInfo(date.month() + 1, date.year()); |
src/hooks/useQueryParams.ts
Outdated
Comment on lines
3
to
13
| /** | ||
| * useQueryParams hook - query params를 다루기 위한 hook | ||
| * UI 상태를 query params로 관리하기 위한 hook | ||
| * @param queryKey | ||
| */ | ||
| const useQueryParams = <T extends string>({ queryKey }: { queryKey: T }) => { | ||
| const searchParams = useSearchParams(); | ||
| const router = useRouter(); | ||
| const pathname = usePathname(); | ||
| const queryParams = searchParams.get(queryKey) as string | undefined; | ||
|
|
There was a problem hiding this comment.
queryparam 이라는 네이밍을 보고 처음에는 react-query에 관련된 로직이라고 생각했었던거같아요 🤔
There was a problem hiding this comment.
useSearchParamState 로 변경할게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
closed #468
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
사용 방법
🌄 스크린샷
2024-02-05.1.21.24.mov
📚 참고
피그마 : https://www.figma.com/file/waOSgkTYJKQdMHXnGPlOum/%5BDEV%5D-Design-Guide?type=design&node-id=4467-55942&mode=design&t=bxPzMOxk49mU79Eu-11
관련 슬랙 : https://depromeet14th.slack.com/archives/C0647U2UG05/p1707054903589829