[Fix] QA 수정사항 반영 및 디자인 시스템 수정사항 반영 #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
컬러값 수정됨, blur 추가됨
아이콘 2개 들어가도록 컴포넌트 구조 수정, 여백 미세 조정됨
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wade3420
approved these changes
Jan 31, 2024
| @@ -5,6 +5,7 @@ import { css } from '@/styled-system/css'; | |||
| import Button from '../Button/Button'; | |||
| import Icon from '../Icon'; | |||
|
|
|||
| // 이거 여기에 있는 이유가? | |||
| function RightComponentHeader({ rightButtonText = '완료', rightButtonProps, title }: TextButtonHeaderType) { | |||
There was a problem hiding this comment.
마이프로필 레이아웃때문에 만들었었는데 쓰이는 곳없으면 지워도 될듯
원래 의도는 (icon, button 상관없이 component 로 받아서 사용하려고 만드려했는데 사용 하는 곳 없으면 지워도 될 것 같아요
There was a problem hiding this comment.
음 말해준 의도랑 다른것 같은데, props 보면 TextButtonHeaderType 예요!
말해준 의도가 맞는지 다시 한번 확인해주실 수 있을까요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항