[Task] 팔로우 팔로워 기능 구현 #419
Merged
[Task] 팔로우 팔로워 기능 구현 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/follow-mission-api
[Task] 팔로우 미션 리스트 api , 팔로우 멤버 리스트 msw 연결
[Feat] 닉네임 검색 페이지 구현
wade3420
requested review from
woobottle,
JUNOSHON and
sumi-0011
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
woobottle
approved these changes
Jan 28, 2024
| @@ -3,25 +3,29 @@ import FollowSummary from '@/app/home/FollowSummary'; | |||
| import MissionList from '@/app/home/MissionList'; | |||
| import { flex } from '@styled-system/patterns'; | |||
|
|
|||
| import { useProfileId } from './ProfileIdProvider'; | |||
| interface ProfileContentProps { | |||
There was a problem hiding this comment.
좀 사소한 것인것 같지만
FollowContent에 ProfileContentProps를 받는것 같아 의도된 것일지 궁금해요~!
There was a problem hiding this comment.
이름 바꾸다가 저 Props는 이름 못바꾼듯합니다 우선 머지하고 여기 리뷰 반영하는 pr 다시 열게요!
| @@ -30,3 +40,42 @@ const listCss = flex({ | |||
| flexDirection: 'column', | |||
| gap: '8px', | |||
| }); | |||
|
|
|||
| export function MissionFollowListInner({ followId }: { followId: number }) { | |||
There was a problem hiding this comment.
이 친구는 컴포넌트 정의가 이곳에서 된 이유가 궁금해요!!
There was a problem hiding this comment.
이것도 따로 리팩토링해야하는 부분입니다 TODO로 남겨둘게요!
| export default function Home() { | ||
| const [followData, setFollowData] = useState<FollowDataState>(null); |
There was a problem hiding this comment.
홈에서 follow를 알고 있어야 하는게 몬가몬가 한데 나중에 같이 이야기 하시죵~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
#397
#396
#384
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
사용 방법
🌄 스크린샷
📚 참고