Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19785: Remove Air Force portal link from results page DUW v2 #33011

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Nov 14, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

New guidance from stakeholder to remove the portal link and have Veterans use the pdf instead for DUW v2

Related issue(s)

#19785

Testing done

Tested locally with the review screen below and should no longer show the portal link
How_To_Apply_For_A_Discharge_Upgrade___Veterans_Affairs_and_Yahoo_Prize_H2H-Pts_1238800_-_King_of_the_Hill___Fantasy_Football___Yahoo__Sports

Screenshots

How_To_Apply_For_A_Discharge_Upgrade___Veterans_Affairs
How_To_Apply_For_A_Discharge_Upgrade___Veterans_Affairs
How_To_Apply_For_A_Discharge_Upgrade___Veterans_Affairs
How_To_Apply_For_A_Discharge_Upgrade___Veterans_Affairs

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@chriskim2311 chriskim2311 marked this pull request as ready for review November 14, 2024 00:35
@chriskim2311 chriskim2311 requested review from a team as code owners November 14, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants