-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Confirmation Page: Successful submit flow (with claim id, less than 30 seconds) - part 2 #32957
Merged
+354
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinec-fftc
added
the
disability-compensation
Label used for Pull Requests that impact Disability Compensation claims (526EZ)
label
Nov 8, 2024
18 tasks
va-vfs-bot
temporarily deployed
to
master/dbex/95237-conf-part-2/main
November 8, 2024 22:14
Inactive
aurora-a-k-a-lightning
previously approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thank you :)
tommasina-va
previously approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice new name formatting utility too!
sethdarragile6
previously approved these changes
Nov 12, 2024
christinec-fftc
dismissed stale reviews from sethdarragile6, tommasina-va, and aurora-a-k-a-lightning
via
November 13, 2024 00:01
6d49a87
bacitracin
approved these changes
Nov 13, 2024
tommasina-va
approved these changes
Nov 13, 2024
aurora-a-k-a-lightning
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
disability-compensation
Label used for Pull Requests that impact Disability Compensation claims (526EZ)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
team: @department-of-veterans-affairs/dbex-trex
toggle cleanup: department-of-veterans-affairs/va.gov-team#95247
Related issue(s)
department-of-veterans-affairs/va.gov-team#95237
Testing done
Screenshots
What areas of the site does it impact?
526ez
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?