Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Confirmation Page: Successful submit flow (with claim id, less than 30 seconds) - part 2 #32957

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

christinec-fftc
Copy link
Contributor

@christinec-fftc christinec-fftc commented Nov 8, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Part 2 of implementing the new confirmation page for successful submissions
  • Adds all the sections after the success alert, using the confirmation view pattern

team: @department-of-veterans-affairs/dbex-trex
toggle cleanup: department-of-veterans-affairs/va.gov-team#95247

Related issue(s)

department-of-veterans-affairs/va.gov-team#95237

Testing done

  • Unit tests added, verified e2e successful (regression), manual testing

Screenshots

desktop mobile
desktop-confirmation-page squished-confirmation-page

What areas of the site does it impact?

526ez

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@christinec-fftc christinec-fftc added the disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) label Nov 8, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/95237-conf-part-2/main November 8, 2024 22:14 Inactive
Copy link
Contributor

@aurora-a-k-a-lightning aurora-a-k-a-lightning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you :)

tommasina-va
tommasina-va previously approved these changes Nov 12, 2024
Copy link
Contributor

@tommasina-va tommasina-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice new name formatting utility too!

sethdarragile6
sethdarragile6 previously approved these changes Nov 12, 2024
@christinec-fftc christinec-fftc marked this pull request as ready for review November 13, 2024 15:24
@christinec-fftc christinec-fftc requested review from a team as code owners November 13, 2024 15:24
@christinec-fftc christinec-fftc merged commit ed99a38 into main Nov 13, 2024
83 of 86 checks passed
@christinec-fftc christinec-fftc deleted the dbex/95237-conf-part-2 branch November 13, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Confirmation Page: Successful submit flow (with claim id, less than 30 seconds) - part 2
6 participants