This repository was archived by the owner on May 1, 2018. It is now read-only.
hw2 superedriver#33
Open
superedriver wants to merge 11 commits into
Open
Conversation
Owner
|
but this solution is hardcoded |
Author
|
Nothing was said in task about solution has to be "hardcoded" or not. |
Owner
|
nice |
denysxftr
reviewed
Nov 22, 2016
| expect(subject.call(env)).to eq [200, {}, ['post show page']] | ||
| end | ||
|
|
||
| it 'not matches request if deep nested post url' do |
Owner
|
looks good to me |
# Conflicts: # hw2/lib/router.rb
denysxftr
reviewed
Dec 4, 2016
|
|
||
| it 'successfully responds' do | ||
| expect(subject) | ||
| .to eq([200, {"Content-Type"=>"text/plain"}, ["{\"a\"=>\"b\", \"e\"=>\"r\"}"]]) |
Owner
There was a problem hiding this comment.
you can you percent literals https://github.com/bbatsov/ruby-style-guide#percent-literals
Owner
|
nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.