Skip to content
This repository was archived by the owner on May 1, 2018. It is now read-only.

Fastman kottans homework#13

Open
fastmanV wants to merge 11 commits into
denysxftr:masterfrom
fastmanV:master
Open

Fastman kottans homework#13
fastmanV wants to merge 11 commits into
denysxftr:masterfrom
fastmanV:master

Conversation

@fastmanV
Copy link
Copy Markdown

@fastmanV fastmanV commented Nov 6, 2016

No description provided.

@fastmanV fastmanV closed this Nov 14, 2016
@fastmanV fastmanV reopened this Nov 14, 2016
Comment thread hw2/lib/router.rb
.reject {|val| val.nil?}

if get_routes.empty?
return [404, {}, ['404 error']]
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need return here

Comment thread hw2/lib/router.rb
if get_routes.empty?
return [404, {}, ['404 error']]
else
return @routes[http_method][get_routes[0]].call(env)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants