Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(testing): improve bdd testing #5136

Merged
merged 3 commits into from
Jun 25, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 134 additions & 0 deletions testing/bdd_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@ import {
assert,
assertEquals,
assertObjectMatch,
assertRejects,
assertStrictEquals,
assertThrows,
} from "@std/assert";
import {
after,
afterAll,
afterEach,
before,
beforeAll,
beforeEach,
describe,
Expand Down Expand Up @@ -543,6 +547,14 @@ Deno.test("it()", async (t) => {
}),
);

await t.step(
"minimum options (skip)",
async () =>
await assertMinimumOptions((fn) => {
assertEquals(it.skip({ name: "example", fn }), undefined);
iuioiua marked this conversation as resolved.
Show resolved Hide resolved
}),
);

await t.step("all options", async () =>
await assertAllOptions((fn) => {
assertEquals(
Expand Down Expand Up @@ -1143,6 +1155,17 @@ Deno.test("describe()", async (t) => {
}),
);

await t.step(
"minimum options (skip)",
async () =>
await assertMinimumOptions((fns) => {
const suite = describe.skip({ name: "example" });
assert(suite && typeof suite.symbol === "symbol");
assertEquals(it({ suite, name: "a", fn: fns[0] }), undefined);
assertEquals(it({ suite, name: "b", fn: fns[1] }), undefined);
}),
);

await t.step(
"all options",
async () =>
Expand Down Expand Up @@ -1587,6 +1610,25 @@ Deno.test("describe()", async (t) => {
),
);

await t.step(
"in callback (using after, before aliases)",
async () =>
await assertHooks(
({ beforeAllFn, afterAllFn, beforeEachFn, afterEachFn, fns }) => {
describe("example", () => {
before(beforeAllFn);
after(afterAllFn);

beforeEach(beforeEachFn);
afterEach(afterEachFn);

assertEquals(it({ name: "example 1", fn: fns[0] }), undefined);
assertEquals(it({ name: "example 2", fn: fns[1] }), undefined);
});
},
),
);

await t.step(
"in options",
async () =>
Expand Down Expand Up @@ -1874,4 +1916,96 @@ Deno.test("describe()", async (t) => {
},
);
});

await t.step(
"mutiple hook calls",
async () => {
using test = stub(Deno, "test");
const context = new TestContext("example");
const beforeAllFn = spy();
const afterAllFn = spy();
const beforeEachFn = spy();
const afterEachFn = spy();

const nested = {
beforeAllFn: spy(),
afterAllFn: spy(),
beforeEachFn: spy(),
afterEachFn: spy(),
};
try {
describe("example multiple hooks", () => {
beforeAll(beforeAllFn);
beforeAll(beforeAllFn);
afterAll(afterAllFn);
afterAll(afterAllFn);
beforeEach(beforeEachFn);
beforeEach(beforeEachFn);
afterEach(afterEachFn);
afterEach(afterEachFn);

describe("nested", () => {
beforeAll(nested.beforeAllFn);
beforeAll(nested.beforeAllFn);
afterAll(nested.afterAllFn);
afterAll(nested.afterAllFn);
beforeEach(nested.beforeEachFn);
beforeEach(nested.beforeEachFn);
afterEach(nested.afterEachFn);
afterEach(nested.afterEachFn);
it({ name: "example 1", fn() {} });
it({ name: "example 2", fn() {} });
});
});
const call = test.calls[0];
const options = call?.args[0] as Deno.TestDefinition;
await options.fn(context);
} finally {
TestSuiteInternal.reset();
}

assertSpyCalls(beforeAllFn, 2);
assertSpyCalls(afterAllFn, 2);
assertSpyCalls(beforeEachFn, 4);
assertSpyCalls(afterEachFn, 4);

assertSpyCalls(nested.beforeAllFn, 2);
assertSpyCalls(nested.afterAllFn, 2);
assertSpyCalls(nested.beforeEachFn, 4);
assertSpyCalls(nested.afterEachFn, 4);
},
);

await t.step("throws if called with wrong suite object", () => {
assertThrows(
// deno-lint-ignore no-explicit-any
() => describe({ name: "", suite: {} as any, fn: () => {} }),
Error,
"suite does not represent a registered test suite",
);
});

await t.step(
"throws if nested test case is called with permission option",
async () => {
using test = stub(Deno, "test");
const context = new TestContext("example");
try {
describe("foo", () => {
describe("bar", { permissions: { read: true } }, () => {
it("baz", () => {});
});
});
const call = test.calls[0];
const options = call?.args[0] as Deno.TestDefinition;
await assertRejects(
async () => await options.fn(context),
Error,
"permissions option not available for nested tests",
);
} finally {
TestSuiteInternal.reset();
}
},
);
});