Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dotenv): improve dotenv docs #5095

Merged
merged 2 commits into from
Jun 21, 2024
Merged

docs(dotenv): improve dotenv docs #5095

merged 2 commits into from
Jun 21, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 20, 2024

This PR improves dotenv docs.

Some examples need the setup of actual .env files. Such examples are tagged as no-eval

part of #3764

@kt3k kt3k mentioned this pull request Jun 20, 2024
38 tasks
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (bd55f3b) to head (ca58a17).
Report is 3 commits behind head on main.

Current head ca58a17 differs from pull request most recent head db6d62f

Please upload reports for the commit db6d62f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5095      +/-   ##
==========================================
+ Coverage   92.57%   92.70%   +0.12%     
==========================================
  Files         481      482       +1     
  Lines       38701    38718      +17     
  Branches     5447     5462      +15     
==========================================
+ Hits        35828    35893      +65     
+ Misses       2818     2770      -48     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* ```ts
*
* @example Using with options
* ```ts no-eval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a brief description explaining what this snippet is doing?

dotenv/mod.ts Show resolved Hide resolved
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kt3k kt3k merged commit 21e8ece into denoland:main Jun 21, 2024
13 checks passed
@kt3k kt3k deleted the document-dotenv branch June 21, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants