test(jsonc): remove dead code and improve testing #5093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
commented
Jun 20, 2024
Comment on lines
+11
to
+13
| import "./testdata/JSONTestSuite/test.ts"; | ||
| import "./testdata/node-jsonc-parser/test.ts"; | ||
| import "./testdata/test262/test.ts"; |
There was a problem hiding this comment.
I think these test cases used to run without these imports, but currently they are not discovered by deno test command.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5093 +/- ##
==========================================
+ Coverage 92.51% 92.60% +0.09%
==========================================
Files 481 482 +1
Lines 38719 38731 +12
Branches 5441 5449 +8
==========================================
+ Hits 35819 35867 +48
+ Misses 2845 2809 -36
Partials 55 55 ☔ View full report in Codecov by Sentry. |
iuioiua
changed the title
iuioiua
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the test coverage of
jsoncfrom 85.26% to 97.42% (missed lines are reduced from 46 to 8)part of #3713