Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): remove dead code #4849

Merged
merged 1 commit into from
May 24, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 24, 2024

These utils don't seem used from anywhere

This improves the test coverage. Related: #3713

@github-actions github-actions bot added the yaml label May 24, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see this done. Nice!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (082107b) to head (13318ff).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4849      +/-   ##
==========================================
+ Coverage   91.97%   92.04%   +0.06%     
==========================================
  Files         487      487              
  Lines       41539    41535       -4     
  Branches     5365     5365              
==========================================
+ Hits        38207    38230      +23     
+ Misses       3274     3247      -27     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit 860cf0e into denoland:main May 24, 2024
10 checks passed
@kt3k kt3k deleted the refactor-yaml-remove-unused branch May 24, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants