fix(node): respect process.exitCode when exiting #1628
Conversation
node/process.ts
Outdated
| super.emit("exit", process.exitCode); | ||
| Deno.exit(process.exitCode || 0); |
There was a problem hiding this comment.
This is probably wrong - if there are more "unload" listeners attached they will never be run. Opened the PR to get discussion going.
There was a problem hiding this comment.
@bnoordhuis any ideas how we tackle that except adding functionality equivalent to process.exitCode directly into CLI?
There was a problem hiding this comment.
This is probably wrong - if there are more "unload" listeners attached they will never be run. Opened the PR to get discussion going.
I have pushed a fix for this to the PR.
There was a problem hiding this comment.
This PR is blocked on denoland/deno#12888. This PR falsely makes it look like tests that fail actually succeed, because all deno test isolates exit with code 0 if they import std/node/process.ts anywhere now.
|
@bnoordhuis actually I was mistaken during the call, this PR is not yet ready. |
|
This should now work properly, however we should probably wait until denoland/deno#12938 is merged before merging this one. |
|
@bartlomieju, denoland/deno#12938 was cancelled. Is this PR still valid? |
|
Gently pinging @kt3k. |
|
@bartlomieju, this appears to no longer be an issue according to #1627 (comment) |
|
Thanks for checking @iuioiua, closing without a merge. |
Closes #1627