Issue 442 (#443)

denodrivers · Feb 2, 2024 · 427b77d · 427b77d · github-actions · Feb 2, 2024
1 parent 63d3d22
commit 427b77d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/client.ts b/client.ts
@@ -197,6 +197,10 @@ export abstract class QueryClient {
    * https://www.postgresql.org/docs/14/sql-set-transaction.html
    */
   createTransaction(name: string, options?: TransactionOptions): Transaction {
+    if (!name) {
+      throw new Error("Transaction name must be a non-empty string");
+    }
+
     this.#assertOpenConnection();
 
     return new Transaction(

diff --git a/tests/query_client_test.ts b/tests/query_client_test.ts
@@ -10,6 +10,7 @@ import {
   assertEquals,
   assertObjectMatch,
   assertRejects,
+  assertThrows,
 } from "./test_deps.ts";
 import { getMainConfiguration } from "./config.ts";
 import { PoolClient, QueryClient } from "../client.ts";
@@ -855,6 +856,18 @@ Deno.test(
   }),
 );
 
+Deno.test(
+  "Transaction parameter validation",
+  withClient((client) => {
+    assertThrows(
+      // deno-lint-ignore ban-ts-comment
+      // @ts-expect-error
+      () => client.createTransaction(),
+      "Transaction name must be a non-empty string",
+    );
+  }),
+);
+
 Deno.test(
   "Transaction",
   withClient(async (client) => {