Fix subtle bug for SIMD finding new line in chapter 10-4#96
Open
YukunJ wants to merge 1 commit intodendibakh:mainfrom
Open
Fix subtle bug for SIMD finding new line in chapter 10-4#96YukunJ wants to merge 1 commit intodendibakh:mainfrom
YukunJ wants to merge 1 commit intodendibakh:mainfrom
Conversation
Owner
|
Yes, I decided to keep the code as simple as possible. |
5b69e52 to
ff2cb64
Compare
Author
|
Sure that makes sense. I will add a comment for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief:
the code might be incorrect when there are more than 1 newliner
\nin 8-byte chunks. Since we are shiftingmaskafter we find a newliner,eolPosis a relative position (relative to mask) in this chunk. Butuint32_t curLen = (pos - lineBeginPos) + eolPos;is an absolute position.understood this is just demo purpose. But shift 8 bytes is UB.
I had a test version on this working here (dendibakh/perf-ninja@cf70700)