Skip to content

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Sep 14, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12912

Description

Introduce new Event Collector: Saviynt Enterprise Identity Cloud (EIC).

Must have

  • Tests
  • Documentation

@samuelFain samuelFain self-assigned this Sep 14, 2025
Copy link

github-actions bot commented Sep 14, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/SaviyntEIC/Integrations/SaviyntEICEventCollector
   SaviyntEICEventCollector.py2125972%61–62, 75–76, 80, 86–89, 91–92, 99, 103, 118–119, 123, 129–134, 141, 145, 162–168, 170–171, 173, 177, 180–187, 190–191, 223, 254, 292–294, 323–324, 551, 553, 558–560, 562–563
TOTAL2125972% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 2.470s ⏱️

@samuelFain samuelFain added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Sep 14, 2025
@samuelFain samuelFain marked this pull request as ready for review September 14, 2025 17:54
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, check my comments.

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@talihaff
Copy link
Contributor

talihaff commented Sep 17, 2025

@samuelFain doc approved

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@samuelFain samuelFain merged commit 3290480 into master Sep 18, 2025
19 checks passed
@samuelFain samuelFain deleted the sf-saviynt-eic-collector branch September 18, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants