Skip to content

Conversation

mcvic1rj
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

No issue created

Description

UrlScan's API for search can utilize other parameters than what the current command forces you into.
This change adds a "raw" searchType to the !urlscan-search command, allowing the user to specify the full formatted query string.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2025

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jun 17, 2025
@content-bot content-bot changed the base branch from master to contrib/mcvic1rj_url-scan-raw-search June 17, 2025 15:59
@content-bot content-bot requested a review from itssapir June 17, 2025 15:59
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @itssapir will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @mcvic1rj, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@itssapir
Copy link
Contributor

Hi @mcvic1rj,
Thank you for your contribution!
Please ensure you fill the contribution form so we can start reviewing you changes.

Thanks.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Jun 19, 2025
@itssapir
Copy link
Contributor

Hi @mcvic1rj,
Just a quick update, this is pending a review by the partner responsible for the pack.

Thank you for your patience on this matter.

Copy link

@fw42 fw42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! @heipei (from urlscan) asked me to take a look at this PR for him.

Not super familiar with this codebase but all the changes here look reasonable and correct to me.

👍

For the next person: Using ?w=1 makes this diff a lot easier to read.

@heipei
Copy link
Contributor

heipei commented Jul 3, 2025

Approved from our end.

Copy link
Contributor

@itssapir itssapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mcvic1rj,
See my comment.

Also, please fix the errors in the pre-commit check.

I am available here or on slack for any question/comment you have.
Thanks again.

@itssapir
Copy link
Contributor

Hi @mcvic1rj, there is still a small error in the pre-commit regarding the pack version. Once thats fixed we can proceed.

Thanks.

@itssapir itssapir added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 21, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4237634

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 21, 2025
@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: RN106.
The following errors cannot be ignored: RN106.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: RN106.

Verdict: PR can be force merged from validate perspective? ✅

@itssapir itssapir merged commit 3046044 into demisto:contrib/mcvic1rj_url-scan-raw-search Jul 21, 2025
22 checks passed
@content-bot content-bot mentioned this pull request Jul 21, 2025
5 tasks
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

itssapir added a commit that referenced this pull request Jul 21, 2025
* Added new search method (raw)

* add release notes and documentation on command change

* Update context to match format for command, and updated command documentation

* lint fixes

* Lint fixes

* Fix release version

* Update Packs/UrlScan/ReleaseNotes/1_2_20.md



---------

Co-authored-by: Ryan McVicar <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
TOUFIKIzakarya pushed a commit to TOUFIKIzakarya/content that referenced this pull request Jul 24, 2025
* Added new search method (raw)

* add release notes and documentation on command change

* Update context to match format for command, and updated command documentation

* lint fixes

* Lint fixes

* Fix release version

* Update Packs/UrlScan/ReleaseNotes/1_2_20.md



---------

Co-authored-by: Ryan McVicar <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants