Skip to content

addded integration #40261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: contrib/qmasters-ltd_cisco-esa-enhancement
Choose a base branch
from

Conversation

ronh1
Copy link
Contributor

@ronh1 ronh1 commented Jun 15, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

The PR including the enhancement to Cisco ESA integration. New commands and updating messages existing commands.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jun 15, 2025
@content-bot content-bot changed the base branch from master to contrib/qmasters-ltd_cisco-esa-enhancement June 15, 2025 11:18
@content-bot content-bot requested a review from itssapir June 15, 2025 11:18
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @itssapir will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @ronh1, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Jun 15, 2025
@ronh1 ronh1 force-pushed the cisco-esa-enhancement branch 2 times, most recently from 7225dac to 8445507 Compare June 15, 2025 11:51
@ronh1 ronh1 closed this Jun 15, 2025
@ronh1 ronh1 force-pushed the cisco-esa-enhancement branch from 8445507 to b6be4f4 Compare June 15, 2025 12:10
@ronh1 ronh1 reopened this Jun 15, 2025
@ronh1 ronh1 force-pushed the cisco-esa-enhancement branch from 42827c9 to 6bb1805 Compare June 15, 2025 18:55
@ronh1 ronh1 closed this Jun 15, 2025
@ronh1 ronh1 force-pushed the cisco-esa-enhancement branch from 6bb1805 to b6be4f4 Compare June 15, 2025 19:18
@ronh1 ronh1 reopened this Jun 15, 2025
@ronh1 ronh1 closed this Jun 15, 2025
@ronh1 ronh1 force-pushed the cisco-esa-enhancement branch from 2cb82d1 to b6be4f4 Compare June 15, 2025 19:30
@ronh1 ronh1 reopened this Jun 15, 2025
@ronh1 ronh1 force-pushed the cisco-esa-enhancement branch 3 times, most recently from 64081c5 to 857f453 Compare June 16, 2025 08:15
@dantavori dantavori requested review from dantavori and removed request for itssapir June 17, 2025 10:06
@dantavori dantavori assigned dantavori and unassigned itssapir Jun 17, 2025
@ronh1 ronh1 force-pushed the cisco-esa-enhancement branch from 857f453 to b1f3656 Compare June 17, 2025 13:52
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay - looks very good! no critical comments.

I do want to mention that I didn't quite understand why are the mode, group/host name relevant for all commands, especially retrieve/delete ones - would appreciate your explanation.

also note that you have some ruff rules to fix, which caused pre-commit to fail.

required: true
isArray: true
default: true
- name: cisco-esa-file-hash-list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct me if I'm wrong, we retrieve file hash lists, so the command name should be:
cisco-esa-file-hash-list-list (which is funny... @meital-aizen ?)
same for cisco-esa-file-hash-list-create, cisco-esa-file-hash-list-update, and cisco-esa-url-list-list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you right, we did it to avoid the double list. @dmitryzinger @meital-aizen what do you say?

Copy link
Contributor

@julieschwartz18 julieschwartz18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review complete. Please review the comments for the descriptions in the YAML file and regerate the README file accordingly. Thanks!

@julieschwartz18
Copy link
Contributor

@ronh1 please review the recommended edits for the YAML file and regenerate the README file accordingly. In the meantime, I added the label docs-approved. Thanks!

@ronh1
Copy link
Contributor Author

ronh1 commented Jul 1, 2025

Hey @dantavori,
The API provides the option to insert the mode, hostname, and group name of most of the commnads.
https://www.cisco.com/c/en/us/td/docs/security/esa/esa16-0/api_guide/b_Secure_Email_API_Guide_16-0/b_ESA_API_Guide_chapter_010.html

Also the Ruff errors related to the old integration (I’ve written the new commands consistently with the current convention).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants