-
Notifications
You must be signed in to change notification settings - Fork 1.8k
addded integration #40261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: contrib/qmasters-ltd_cisco-esa-enhancement
Are you sure you want to change the base?
addded integration #40261
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @itssapir will know the proposed changes are ready to be reviewed. |
7225dac
to
8445507
Compare
8445507
to
b6be4f4
Compare
42827c9
to
6bb1805
Compare
6bb1805
to
b6be4f4
Compare
2cb82d1
to
b6be4f4
Compare
64081c5
to
857f453
Compare
857f453
to
b1f3656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay - looks very good! no critical comments.
I do want to mention that I didn't quite understand why are the mode, group/host name relevant for all commands, especially retrieve/delete ones - would appreciate your explanation.
also note that you have some ruff rules to fix, which caused pre-commit to fail.
required: true | ||
isArray: true | ||
default: true | ||
- name: cisco-esa-file-hash-list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct me if I'm wrong, we retrieve file hash lists, so the command name should be:
cisco-esa-file-hash-list-list
(which is funny... @meital-aizen ?)
same for cisco-esa-file-hash-list-create
, cisco-esa-file-hash-list-update
, and cisco-esa-url-list-list
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you right, we did it to avoid the double list. @dmitryzinger @meital-aizen what do you say?
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc review complete. Please review the comments for the descriptions in the YAML file and regerate the README file accordingly. Thanks!
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
...Integrations/CiscoEmailSecurityApplianceIronPortV2/CiscoEmailSecurityApplianceIronPortV2.yml
Outdated
Show resolved
Hide resolved
Packs/IronPort/Integrations/CiscoEmailSecurityApplianceIronPortV2/README.md
Show resolved
Hide resolved
@ronh1 please review the recommended edits for the YAML file and regenerate the README file accordingly. In the meantime, I added the label docs-approved. Thanks! |
Hey @dantavori, Also the Ruff errors related to the old integration (I’ve written the new commands consistently with the current convention). |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
The PR including the enhancement to Cisco ESA integration. New commands and updating messages existing commands.
Must have