-
Notifications
You must be signed in to change notification settings - Fork 168
M/callback fixes #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dacode45
wants to merge
11
commits into
deltaphc:master
Choose a base branch
from
raylib-rs:m/callback-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
M/callback fixes #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dacode45 <[email protected]>
* Format and update safety docs of DataBuf * Mark DataBuf deref as inline * Make alloc return MaybeUninit and add single-value DataBuf * Make requested changes * Further ensure safety of DataBuf * Sorry, my IDE told me that feature was stable * Address recent safety comments * Remove unnecessary safety comment * Fix possible non-drop of freed DataBuf * Reword doc * Update safety docs on DataBuf::deref * Add unit tests and more options for initializing DataBuf * Make accessors on RlManaged unsafe * Move semicolon * Move DataBuf to own file and enable lints * Expose databuf in prelude * Fix Path not being imported correctly --------- Co-authored-by: Amy Wilder <[email protected]>
* Add feature "drm" to build Raylib for PLATFORM=DRM The feature "drm" should usually be enabled together with "opengl_es_20". Also introduced a feature "legacy_rpi" for the deprecated Raspberry Pi platform build. Previously this was automatically enabled on armv7-unknown-linux platforms, thus breaking builds on all other armv7 platforms. Also, users probably expect Raspberry Pi builds to default to PLATFORM=Desktop. Both desktop and DRM builds work on the Raspberry Pi with these changes. * Fix char type on ARM platforms Same problem as fixed in #88 (see #74 and deltaphc#191). --------- Co-authored-by: Philipp Maierhoefer <[email protected]>
…r than size in bytes (#212) * update AudioStream update func with element size instead of byte size * proper commit, no commented out code * remove commented out ffi code * beginnings of corrections from amy's review, moving closer to the original raylib c example * update closer to raylib core example * fix misunderstanding about casting issue locaiton from https://github.com/raylib-rs/raylib-rs/pull/212/files#r2191026194 * update Sound update and AudioStream Update with added test * match the original raylib manual audio stream update behavior exactly match the * Last review draft for PR, update comments, and test
…deprecated issues) (#231) * - clean up tests hidden by cargo naming issue - update data.rs and callback.rs to catch up to new raylib binding generation (cherry picked from commit 5c5a053) * update LoadFontData binding argument change from upstream (compile errors focus) (cherry picked from commit 3d3911b) * raysan5/raylib@ba046a5 fixes upstream now all green for doc tests (cherry picked from commit ab4e74f) * get rid of lifetime styling warnings (deprecated functions included, perhaps ignore) (cherry picked from commit 43fa6d9) * cleaner attempt of PR: pin submodule to ba046a5d (sync to upstream API; doc tests green)
Co-authored-by: Dacode45 <[email protected]>
* - clean up tests hidden by cargo naming issue - update data.rs and callback.rs to catch up to new raylib binding generation (cherry picked from commit 5c5a053) * update LoadFontData binding argument change from upstream (compile errors focus) (cherry picked from commit 3d3911b) * raysan5/raylib@ba046a5 fixes upstream now all green for doc tests (cherry picked from commit ab4e74f) * get rid of lifetime styling warnings (deprecated functions included, perhaps ignore) (cherry picked from commit 43fa6d9) * cleaner attempt of PR: pin submodule to ba046a5d (sync to upstream API; doc tests green) * refactored audio raw stream callback for closure usage and added clear sample size, mono vs stereo compatability (cherry picked from commit 8419a13) # Conflicts: # raylib-sys/raylib
…o m/callback-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #239