-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add russian translation #40
Conversation
Co-authored-by: iequidoo <[email protected]>
@iequidoo Now that it's deployed, can you confirm whether the translation is shown for you? |
i.delta.chat still says "Say hello to iequidoo" while https://delta.chat brings me to https://delta.chat/ru/. FF 115.10.0esr |
I'm not sure if it was redirecting before, but I thought it would at least check for preferred language. I can access French https://i.delta.chat/?lang=fr and Russian https://i.delta.chat/?lang=ru with a query parameter. |
Yes, i tried to change my preferred language in FF, but that didn't help for http://i.delta.chat. But if i add EDIT: Now it works if i change my preferred language, but it looks that FF caches smth so i need to open a "New private window". Not that important i think. |
Language gets stored into "local storage" by this i18next library. |
Can a native speaker take a second look at this?
Also I'm not sure if the localization scheme works at all right now, switching chromium to french already doesn't work for me on main branch, I still see the english text. But tests pass, and updating i18next.js doesn't change anything, so maybe it's fine?
related: #39