Gallery - context menu (delete only) #952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the new ios13 menu. What's still missing is previews for videos though. |
|
looks great the new context menu! and also a good place to make some experiences with them :)
|
|
closing in favor of #985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #944
This PR adds a context menu to the GalleryViewController. The context menu only shows delete-action (as required in #944) but can be easily altered with other options like sharing images etc.
Since iOS13 apple introduced a new type of context menu, so I implemented two context menus that are shown depending on the iOS version. To review I suggest using an iOS12 simulator.
I had to move the
prepareContextMenu-method in chatList to viewWillAppear. Otherwise the menu manipulation inGallerViewControllerwould override the ChatList's context menu.iOS12-style context menu
iOS13-style context menu
