Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: outgoing bg color for outgoing stickers #4456

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Jan 6, 2025

Before:
image image

After:
image image

For incoming messages the color is also respective:

image image

Closes #4453.
The bug (if you can call it that) was introduced in f83ce46.
Similar commit: 8259aad.

CI failures are to be fixed in #4426.

Closes #4453.
The bug (if you can call it that) was introduced in f83ce46.
Similar commit: 8259aad.
@WofWca WofWca force-pushed the wofwca/fix-sticker-quote-bg branch from 2a9134e to d66b8a4 Compare January 6, 2025 14:57
@WofWca WofWca marked this pull request as ready for review January 6, 2025 15:04
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for fixing that detail! 🙏

code lgtm as far as i can tell, but i also tested and it works as expected :)

@r10s
Copy link
Member

r10s commented Jan 6, 2025

For incoming messages the color is also respective

i do not really understand that hint and the image: incoming messages were always fine afaik - or do you just want to point out that that part was unchanged? :)

@WofWca
Copy link
Collaborator Author

WofWca commented Jan 6, 2025

or do you just want to point out that that part was unchanged? :)

Yes.

@WofWca WofWca merged commit e813b08 into main Jan 6, 2025
13 of 14 checks passed
@WofWca WofWca deleted the wofwca/fix-sticker-quote-bg branch January 6, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong background color when showing "reply with sticker"
2 participants