Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: keep line breaks in quoted messages #4360

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Nov 27, 2024

Before:

image

After:

image
image

Closes #4354.
Supersedes #4356.

The bug was introduced in 78fef8b.

@nicodh please see if this is better. As suggested in #4356 (review), I utilize the white-space property for this.

@WofWca WofWca force-pushed the wofwca/fix-4354-quote-linebreaks branch from 840093d to 0a84951 Compare November 27, 2024 11:04
@WofWca WofWca marked this pull request as ready for review November 27, 2024 11:06
Closes #4354.
Supersedes #4356.

The bug was introduced in 78fef8b.

Co-authored-by: Nico de Haen <[email protected]>
@WofWca WofWca force-pushed the wofwca/fix-4354-quote-linebreaks branch from 0a84951 to f70f1b0 Compare November 27, 2024 11:08
@WofWca WofWca requested a review from nicodh November 27, 2024 11:10
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@nicodh nicodh merged commit fc57822 into main Nov 27, 2024
7 checks passed
@nicodh nicodh deleted the wofwca/fix-4354-quote-linebreaks branch November 27, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lineends are lost in quotes
2 participants