perf: add useMemo for contactsAndExtraItems

deltachat · Jan 6, 2025 · 94893d5 · 94893d5
1 parent ae1fdcb
commit 94893d5
Showing 1 changed file with 24 additions and 9 deletions.
diff --git a/packages/frontend/src/components/dialogs/CreateChat/index.tsx b/packages/frontend/src/components/dialogs/CreateChat/index.tsx
@@ -169,15 +169,30 @@ function CreateChatMain(props: CreateChatMainProps) {
     ADD_BROADCAST_LIST,
     ADD_CONTACT,
   }
-  const contactsAndExtraItems = [
-    ...(needToRenderAddContactQRScan
-      ? [ExtraItemType.ADD_CONTACT_QR_SCAN]
-      : []),
-    ...(needToRenderAddGroup ? [ExtraItemType.ADD_GROUP] : []),
-    ...(needToRenderAddBroadcastList ? [ExtraItemType.ADD_BROADCAST_LIST] : []),
-    ...contactIds,
-    ...(needToRenderAddContact ? [ExtraItemType.ADD_CONTACT] : []),
-  ]
+  const contactsAndExtraItems = useMemo(
+    () => [
+      ...(needToRenderAddContactQRScan
+        ? [ExtraItemType.ADD_CONTACT_QR_SCAN]
+        : []),
+      ...(needToRenderAddGroup ? [ExtraItemType.ADD_GROUP] : []),
+      ...(needToRenderAddBroadcastList
+        ? [ExtraItemType.ADD_BROADCAST_LIST]
+        : []),
+      ...contactIds,
+      ...(needToRenderAddContact ? [ExtraItemType.ADD_CONTACT] : []),
+    ],
+    [
+      ExtraItemType.ADD_BROADCAST_LIST,
+      ExtraItemType.ADD_CONTACT,
+      ExtraItemType.ADD_CONTACT_QR_SCAN,
+      ExtraItemType.ADD_GROUP,
+      contactIds,
+      needToRenderAddBroadcastList,
+      needToRenderAddContact,
+      needToRenderAddContactQRScan,
+      needToRenderAddGroup,
+    ]
+  )
 
   const openQRScan = async () => {
     const [qrCode, qrCodeSVG] =