-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Core now adds a ~ by itself #3520
base: main
Are you sure you want to change the base?
Conversation
Companion for deltachat/deltachat-core-rust#6411. This PR is not meant to change user-visible behavior, we just shifted the responsibility to add the "~" to core. (without this PR, the name would be "~~Alice" sometimes)
tbh, I am a bit skeptical of making core put ~ in front of names, the clients could decide to use different ways to display this information, like using a different color or separated element, or a completely different signal like an icon etc |
but they do not and did not all the years 🤷♂️ - cross platform consistency is also easier by a prefix. also, having a simple approach as a prefixed character, works better for notifications and other places we do not have so much control about the appearance (eg. reaction strings as "NAME reacted 🤷♂️ to MSG") so, i think, that part is fine, if we agree to prefix virtually all names by |
I am not talking about official client only |
and even in WhatsApp where this idea was copied from, the ~ is displayed more specially separated from the name |
problems I can see coming: generation of the avatar letters if the name given by core always starts with ~ |
that's a point |
To test the changes in this pull request, install this apk: |
we can have a new api returning the initials for avatar generation. message parser has methods that can help us with taking exactly the first emoji ( Or easiest would be probably a new field/property that tells his to add |
This PR is not meant to change user-visible behavior, we just shifted the responsibility to add the "~" to core. (without this PR, the name would be "~~Alice" sometimes)
WIP until deltachat/deltachat-core-rust#6411 is merged.