Don't show "0%" at the beginning when being added as second device #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the changes in this pull request, install this apk: |
r10s
approved these changes
Nov 4, 2024
adbenitez
reviewed
Nov 4, 2024
| @@ -84,7 +84,8 @@ public void handleEvent(@NonNull DcEvent event) { | |||
| } else if (permille < 1000) { | |||
| percent = permille/10; | |||
| percentMax = 100; | |||
| statusLineText = getString(R.string.transferring) + String.format(Util.getLocale(), " %d%%", percent); | |||
| String formattedPercent = percent > 0 ? String.format(Util.getLocale(), " %d%%", percent) : ""; | |||
| statusLineText = getString(R.string.transferring) + formattedPercent; | |||
There was a problem hiding this comment.
btw, not related to this PR but this string concatenation is not good, for RTL languages it will not be mirrored properly 🤔
There was a problem hiding this comment.
The good news is that it's not a sentence, so that it's not that bad if the order is wrong for RTL messages. I.e. "10% Transferring..." and "Transferring... 10%" is both right.
adbenitez
approved these changes
Nov 4, 2024
|
Merging since it's a mitigation for a bug that's possibly a regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigation for #3392, follow-up for #3337.
When creating a chatmail account, when logging in to an existing email account, and when importing a backup from the Welcome Activity, we're still showing "0%" even after this PR. So, an alternative to this PR would be to make
percent > 0 ? String.format(Util.getLocale(), " %d%%", percent) : "";into a function and call it from all these places, too, and never show "0%" anywhere ever again.