Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach multiple images #3351

Merged
merged 8 commits into from
Oct 14, 2024
Merged

attach multiple images #3351

merged 8 commits into from
Oct 14, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented Oct 10, 2024

ftr: this "feature break down" is the result from a discussion with users in an 80+ ppl group

this PR allows to select and send multiple images directly from within the app's gallery.

after confirmation, the images are send as separated messages then - similar to images selected from the system gallery.

sending single images is done as usual and unchanged.

this should make the usecase of "sharing quite some holiday images" much easier - even though more advanced things as per-image comment or mini-galleries are not there, let alone sending the images in a single mail. all that would be much more effort and is out of scope currently

Screen.Recording.2024-10-11.at.01.33.59.mov

@r10s r10s requested a review from adbenitez October 10, 2024 23:22
@r10s r10s marked this pull request as ready for review October 10, 2024 23:22
@r10s r10s added the enhancement actually in development, user visible enhancement label Oct 10, 2024
@r10s r10s changed the title attach multimple images attach multiple images Oct 10, 2024
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link
Member

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice improvement!

one step forward to some kind of multi-attachment message, I was thinking that even if it is not practical to send all attachments in a single email, maybe the UI could still group all the images if there is some header/indication of "this images belong to the same message and should be grouped"

@r10s
Copy link
Member Author

r10s commented Oct 14, 2024

yes, that is a a more user-visible step and probably more interesting step than really sending on one email. but already that raises quite some more advanced challenges: download-on-demand, handling different aspect ratios, rotations (sounds easy, but it was quite some effort to settle that for one image :) - probably more.

i'd wait at least until we have deltachat/deltachat-core-rust#5888 settled

@r10s r10s merged commit 86a9da5 into main Oct 14, 2024
2 checks passed
@r10s r10s deleted the r10s/attach-multimple-images branch October 14, 2024 13:58
@r10s r10s changed the title attach multiple images attach multiple images and files Jan 4, 2025
@r10s r10s changed the title attach multiple images and files attach multiple images Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants