-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attach multiple images #3351
attach multiple images #3351
Conversation
To test the changes in this pull request, install this apk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice improvement!
one step forward to some kind of multi-attachment message, I was thinking that even if it is not practical to send all attachments in a single email, maybe the UI could still group all the images if there is some header/indication of "this images belong to the same message and should be grouped"
yes, that is a a more user-visible step and probably more interesting step than really sending on one email. but already that raises quite some more advanced challenges: download-on-demand, handling different aspect ratios, rotations (sounds easy, but it was quite some effort to settle that for one image :) - probably more. i'd wait at least until we have deltachat/deltachat-core-rust#5888 settled |
ftr: this "feature break down" is the result from a discussion with users in an 80+ ppl group
this PR allows to select and send multiple images directly from within the app's gallery.
after confirmation, the images are send as separated messages then - similar to images selected from the system gallery.
sending single images is done as usual and unchanged.
this should make the usecase of "sharing quite some holiday images" much easier - even though more advanced things as per-image comment or mini-galleries are not there, let alone sending the images in a single mail. all that would be much more effort and is out of scope currently
Screen.Recording.2024-10-11.at.01.33.59.mov