[Kernel][Metrics][PR#6] Support TransactionReport to log metrics for a Transaction operation #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
scottsand-db
requested changes
Jan 13, 2025
kernel/kernel-api/src/main/java/io/delta/kernel/metrics/SnapshotMetricsResult.java
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/metrics/TransactionMetricsResult.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/metrics/TransactionMetricsResult.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/metrics/TransactionReport.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/metrics/TransactionReportImpl.java
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/metrics/TransactionReportImpl.java
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/metrics/TransactionMetrics.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/TransactionImpl.java
Outdated
Show resolved
Hide resolved
...kernel-defaults/src/test/scala/io/delta/kernel/defaults/metrics/MetricsReportTestUtils.scala
Outdated
Show resolved
Hide resolved
...kernel-defaults/src/test/scala/io/delta/kernel/defaults/metrics/MetricsReportTestUtils.scala
Show resolved
Hide resolved
scottsand-db
requested changes
Jan 15, 2025
| engineInfo, | ||
| committedVersion, | ||
| transactionMetrics, | ||
| readSnapshot.getSnapshotReport(), |
There was a problem hiding this comment.
what is the readSnapshot of a new table creation? is it just InitialSnapshot? with version = -1?
There was a problem hiding this comment.
kernel/kernel-api/src/main/java/io/delta/kernel/internal/metrics/TransactionReportImpl.java
Show resolved
Hide resolved
...kernel-defaults/src/test/scala/io/delta/kernel/defaults/metrics/TransactionReportSuite.scala
Outdated
Show resolved
Hide resolved
...kernel-defaults/src/test/scala/io/delta/kernel/defaults/metrics/TransactionReportSuite.scala
Outdated
Show resolved
Hide resolved
...kernel-defaults/src/test/scala/io/delta/kernel/defaults/metrics/TransactionReportSuite.scala
Outdated
Show resolved
Hide resolved
...kernel-defaults/src/test/scala/io/delta/kernel/defaults/metrics/TransactionReportSuite.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Adds
TransactionReportfor reporting an attempted or successful transaction.We record
TransactionReporteither after successfully committing the transaction or if an exception is thrown during the commit attempt. We only record a report for failed commit attempts. If there are failures elsewhere, such as while writing the data, they will not be reported.We also add support for serializing
TransactionReports in this PR.How was this patch tested?
Adds unit tests.
Does this PR introduce any user-facing changes?
No.