[Spark] Remove protocol and metadata from incremental checksum computation function #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -213,6 +209,10 @@ trait RecordChecksum extends DeltaLogging { | |||
| // Incrementally compute the new version checksum, if the old one is available. | |||
| val ignoreAddFilesInOperation = | |||
| RecordChecksum.operationNamesWhereAddFilesIgnoredForIncrementalCrc.contains(operationName) | |||
| val protocol = | |||
| actions.collectFirst { case p: Protocol => p }.getOrElse(oldVersionChecksum.protocol) | |||
There was a problem hiding this comment.
If the CRC file is missing Protocol, can oldVersionChecksum.protocol be null?
Same below for Metadata?
sumeet-db
force-pushed
the
pnm_checksum_2
branch
from
8bdbebc to
1b7636e
Compare
prakharjain09
approved these changes
Jan 17, 2025
sumeet-db
force-pushed
the
pnm_checksum_2
branch
from
1b7636e to
a053a31
Compare
sumeet-db
force-pushed
the
pnm_checksum_2
branch
from
a053a31 to
4c6a681
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This is a small refactoring PR that removes protocol and metadata from incremental checksum computation method since they can be easily fetched from the actions.
How was this patch tested?
Existing UTs
Does this PR introduce any user-facing changes?
No