Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformation - circle #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Transformation - circle #139

wants to merge 2 commits into from

Conversation

elcolto
Copy link
Contributor

@elcolto elcolto commented May 9, 2024

Add port of circle calculation. See #25

@elcolto elcolto force-pushed the feature/issue25-circle branch from d3ac535 to 7e5d9cc Compare May 9, 2024 07:12
dellisd
dellisd approved these changes May 16, 2024
View reviewed changes
Copy link
Owner

@dellisd dellisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@dellisd dellisd linked an issue May 16, 2024 that may be closed by this pull request
Transformation - circle #25
Open
@elcolto
Copy link
Contributor Author

elcolto commented May 16, 2024 

45 tests completed, 1 failed
> Task :turf:nativeTest

io.github.dellisd.spatialk.turf.TransformationTest.testCircle[native] FAILED
    kotlin.AssertionError at null:-1
There were failing tests. See the report at: file:///home/runner/work/spatial-k/spatial-k/turf/build/reports/tests/nativeTest/index.html

@dellisd, can't reproduce it locally. Can you give it a try, or have access to the test report?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellisd dellisd dellisd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transformation - circle
2 participants
@elcolto @dellisd