Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add a generic type parameter to
Feature
These changes would lead to several questions. Which are partly already mentioned in #76
features
property inFeatureCollection
and this class itself would always return aList<Feature<Geometry>>
. This would lead to instances checks on each feature. (Could be handled with an exhaustivewhen
)Geometry
type in some cases of aFeatureCollection
is probably known. For example you know, a function will return a FeatureCollection containing onlyLineString
s. This may lead to code like this:On the other hand, a generic type parameter for containing geometries within containing features on
FeatureCollection
is misleading. It doesn't has a direct relation to the FeatureCollection itself and it doesn't match really match the case of polymorphic FeatureCollections. This would always beFeatureCollection<Geometry>
which is kind of redundant to declare this every time for the most cases.Please share some thoughts.