Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arena export (via copy to clipboard) #2478

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

KaelenProctor
Copy link
Contributor

Implements #1181. For the mainboard of the cube it generates the text to copy/paste into Arena, and has a button to copy direct to browser clipboard.

As I would only classify myself as having a working man's knowledge of React/Hooks, happy to adjust in case there are more React-y ways of doing things.

Testing

General

  1. Use Sort/filter buttons apply to the Arena export when the modal opens. Tested several sort changes of the primary and secondary sorts, assuming the rest would work the same
  2. Add and remove cards from the cube, the Arena export list is updated when modal opens
  3. Multiple of the same card are exported and in Arena are counted together

Importing to Arena:

  1. For each set on Arena (including extras like Jumpstart, Anthologies, and remasters) exported the card names via Scryfall. This got me approximately 170 cards per set. Tested over 40 sets.
  2. Imported those names into a Cube
  3. Exported to Arena via copy to clipboard
  4. Imported to Arena

Issues encountered:

  1. The backside of meld cards (ex. Mishra, Lost to Phyrexia) are not found on import to Arena. It does not have the backsides as "cards"
  2. Cards ending with exclamation mark (ex. Fear, Fire, Foes!) cannot be imported (even using Arena export/import). Known bug open with Arena

Screenshots

Export modal
export

Modal after clicking copy to clipboard button
export-after-copy

Example of filter applying when "Use filter" is enabled
filter-applying

Example of filter ignored when "Use filter" is off
filter-not-applied

Sorting applied
sorting

@dekkerglen
Copy link
Owner

This is going to be obsoleted by tailwind css and ts migration, will hold off until that is done and then we can rebase

@KaelenProctor KaelenProctor marked this pull request as draft November 30, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants