Include contents as argument in popstate event #401
Closed
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At Causes, we are using pjax in conjunction with Reactjs. As we have currently implemented things, when using the back and forward buttons (popstate), the following warning is logged: > React attempted to use reuse markup in a container but the checksum > was invalid. This generally means that you are using server rendering > and the markup generated on the server was not what the client was > expecting. React injected new markup to compensate which works but you > have lost many of the benefits of server rendering. Instead, figure > out why the markup being generated is different on the client or > server. To prevent this message from happening, we need a way to clean out the markup that was generated by React components before putting them back on the page. It seems like an event handler that listens to the pjax:popstate event is a reasonable place to do this, but the page's contents are not sent along with that event. This commit includes the contents that will end up on the page when popping state in the pjax:popstate event that is triggered. This will enable us to clean out the bits that are not desired before they hit the page.
|
Would the recent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Causes, we are using pjax in conjunction with Reactjs. As we have
currently implemented things, when using the back and forward buttons
(popstate), the following warning is logged:
To prevent this message from happening, we need a way to clean out the
markup that was generated by React components before putting them back
on the page. It seems like an event handler that listens to the
pjax:popstate event is a reasonable place to do this, but the page's
contents are not sent along with that event.
This commit includes the contents that will end up on the page when
popping state in the pjax:popstate event that is triggered. This will
enable us to clean out the bits that are not desired before they hit the
page.