Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add husky-based commit linting to project (#186) #189

Closed
wants to merge 13 commits into from
Closed

Add husky-based commit linting to project (#186) #189

wants to merge 13 commits into from

Conversation

samayer12
Copy link
Contributor

Fixes #186

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 5, 2024
View reviewed changes
_helpers/dev/cli.mts Fixed Show fixed Hide fixed
_helpers/dev/cli.mts Fixed Show fixed Hide fixed
@samayer12
Copy link
Contributor Author

Reference defenseunicorns/pepr#1388 to see how the E2E test run against Pepr.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 5, 2024
View reviewed changes
_helpers/dev/cli.mts Dismissed Show dismissed Hide dismissed
@samayer12 samayer12 self-assigned this Nov 5, 2024
@samayer12 samayer12 marked this pull request as ready for review November 5, 2024 21:52
@samayer12
Copy link
Contributor Author

samayer12 commented Dec 12, 2024 •
edited
Loading

We're going to do this change in a series of smaller PRs. Closing and will revisit in later PRs that:

  • Add husky without linting
  • For each excellent example, lint the excellent example

@samayer12 samayer12 closed this Dec 12, 2024
This was referenced Dec 12, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btlghrants btlghrants Awaiting requested review from btlghrants

@cmwylie19 cmwylie19 Awaiting requested review from cmwylie19

Assignees

@samayer12 samayer12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add husky-based commit linting to project
1 participant
@samayer12