Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: generate types with quicktype #303

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mike-winberry
Copy link
Collaborator

Description

#302

Creating PR for easy review/discussion

Related Issue

#302

Type of change

  • breaking
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

…mas in the types/quicktype/ folder following the same pattern as before
@mike-winberry mike-winberry changed the title chore(Investigation): generate types with quicktype feat!: generate types with quicktype Sep 11, 2024
@mike-winberry mike-winberry changed the title feat!: generate types with quicktype feat!: generate types with quicktype Sep 11, 2024
…tomatic-and-consistent-conversion-from-the-jsonschema
…tomatic-and-consistent-conversion-from-the-jsonschema
@mike-winberry mike-winberry marked this pull request as ready for review September 19, 2024 17:04
@mike-winberry mike-winberry requested a review from a team as a code owner September 19, 2024 17:04
@mike-winberry
Copy link
Collaborator Author

Marking ready for review to spark discussion and thoughts. This significantly reduces the amount of code to maintain, and allows for quick type exporting in other languages to maintain consistency.

@mike-winberry mike-winberry self-assigned this Sep 19, 2024
@mike-winberry
Copy link
Collaborator Author

still planned:

  • test on lula branch to identify any major breaking changes and assess the conversion work.

…tomatic-and-consistent-conversion-from-the-jsonschema
@brandtkeller
Copy link
Member

Documenting for posterity - would like to see the outputs the of planned integration with a consumer (lula).

Otherwise planning to possibly ADR this solution against some investment in metaschema to determine architectural changes.

@mildwonkey
Copy link

oh yay, I've been wondering why we weren't generating these 😂 !

nitpick: the generated files aren't properly formatted, can you do something to fix that? Perhaps add a go fmt step in the Make file after generating the files? (I confirmed locally that go fmt removes the extra spacing)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

[INVESTIGATION] switch to quicktype for automatic and consistent conversion from the jsonschema
3 participants