Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hicBuildMatrix - redundant memory usage #646

Closed
StephenRicher opened this issue Dec 11, 2020 · 2 comments
Closed

hicBuildMatrix - redundant memory usage #646

StephenRicher opened this issue Dec 11, 2020 · 2 comments

Comments

@StephenRicher
Copy link

Hi,

Thanks for developing this great tool!

When using --region with hicBuildMatrix I have noticed that memory usage is still high even for small matrix regions. This seems to be related to --restrictionCutFile from hicFindRestSite as the rest site file still corresponds to the full genome.

I tried sub-setting the restrictionCutFile to include only regions within my desired region (+/- a buffer of a few regions) and reran hicBuildMatrix. Memory usage was significantly reduced but the matrix appeared to produce identical results.

I guess somewhere in the hicBuildMatrix code the full restrictionCutFile is processed regardless of the --region argument? Would it be possible to consider only the appropriate restriction sites when --region is specified to significantly reduce memory usage.

Thanks,
Stephen

@joachimwolff
Copy link
Collaborator

Hi Stephen,

Thank you for your feedback.

I guess somewhere in the hicBuildMatrix code the full restrictionCutFile is processed regardless of the --region argument? Would it be possible to consider only the appropriate restriction sites when --region is specified to significantly reduce memory usage.

Yes, it is just read as it was given by the user and the region parameter is not considered. I will add it to my TODO list to improve this in a future version.

Best,

Joachim

joachimwolff added a commit that referenced this issue Mar 3, 2021
@joachimwolff
Copy link
Collaborator

Implemented with PR #731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants