Make Muon optimizer easier to enable #7555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ma, Guokai <[email protected]>
Signed-off-by: Ma, Guokai <[email protected]>
delock
force-pushed
the
gma/muon_improv
branch
from
3439b3a to
6592071
Compare
delock
changed the title
sfc-gh-truwase
approved these changes
Sep 12, 2025
|
@delock Can you take care of the unit test and make sure it passes? |
Yes, let me check UT. Thanks for reminding! |
|
Looks like |
|
Hi @loadams the remaining failure in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original Muon optimizer PR (#7509) requires user to explicitly set
use_muonflags inmodel.parameters(), as shown in test https://github.com/deepspeedai/DeepSpeed/blob/master/tests/unit/ops/muon/test_muon.py#L27 .This PR integrate setting of
use_muoninto DeepSpeed before engine initialization. This makes Muon optimizer easier to use. User only needs to change optimizer inconfig.jsonfromAdamWtoMuon, no need to change code. It will solve the following issue #7552