Option to run Wan2GP as a desktop app#1752
Open
tylandercasper wants to merge 3 commits into
Open
Conversation
adds --run-as-chrome-app that takes the location of the chrome exe. It will launch the url in app mode which makes it look like it's a full app
tylandercasper
changed the title
tylandercasper
changed the title
tylandercasper
changed the title
we now launch chrome with a special profile just for the app. This allows it to run separately from any other chrome instances and prevents any accidental drag and drops from opening as new tab in your browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you pass the parameter --app= to the chrome exe it will start a new instance of chrome without any of the browser UI making it appear like a normal app.
This PR adds a new CLI arg "--run-as-chrome-app" which takes the location of the chrome exe
When the server is started it will open the url in app mode.
I also added some basic cleanup so if you close the app it will stop the server and if you stop the server it will close the app.
The beauty of this is that you can now launch Wan2GP in a single step.
For Instance I made a launch.bat file with the text
start "Wan2GP Console" <conda_location>\conda.exe run --live-stream -n wan2gp python wgp.py --run-as-chrome-app "C:\Program Files\Google\Chrome\Application\chrome.exe"(This starts a console with the title "Wan2GP Console" and than loads the app using conda)