[Rewrite] sqrt(x**2) -> abs(x) (#59)#63
Closed
ArthurPendragn wants to merge 4 commits into
Closed
Conversation
- New ops: SQRT, ABS, SQUARE added to NumericOpType + dispatch - Constructor refactor: NumericOp now accepts either a func or a type directly, enabling synthetic nodes (e.g. the replacement ABS op) - x**2 support: BinOp(**2) now canonicalizes to SQUARE, making it rewrite-eligible - New rewrite pass: eliminate_sqrt_square replaces SQUARE → SQRT chains with ABS - Config toggle: AlgebraicRewritesConfig.sqrt_square (default on) - 11 new tests
e-strauss
requested changes
May 6, 2026
Collaborator
e-strauss
left a comment
There was a problem hiding this comment.
Hi @ArthurPendragn thanks for your first contribution :)
Overall the PR looks good I think, I added some minor comments and please take a look at the failing tests. you can also run the test locally with:
cd stratum
pytest -v tests
You can just add commits to this branch, I will squash them during merge.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
added 2 commits
May 7, 2026 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59