Merging the drand fork

Makefile

@@ -2,10 +2,26 @@ tidy:
 	#go install honnef.co/go/tools/cmd/staticcheck@latest
 	go mod tidy
 
-.PHONY: fetch-dependencies
-fetch-dependencies:
-	go get -v -t -d ./...
+generate: tidy
+	go generate ./...
 
-.PHONY: test
-test: fetch-dependencies
-	go test -v ./...
+# Coding style static check.
+lint: tidy
+	@echo "Please setup a linter!"
+	#golangci-lint run
+	#staticcheck go list ./...
+
+
+vet: tidy
+	go vet ./...
+
+test: tidy
+	go test ./...
+
+coverage: tidy
+	go test -json -covermode=count -coverprofile=profile.cov ./... > report.json
+
+# target to run all the possible checks; it's a good habit to run it before
+# pushing code
+check: lint vet test
+	echo "check done"

README.md

@@ -1,7 +1,7 @@
-[![Docs](https://img.shields.io/badge/docs-current-brightgreen.svg)](https://godoc.org/github.com/drand/kyber)
-[![CircleCI](https://circleci.com/gh/drand/kyber/tree/master.svg?style=svg)](https://circleci.com/gh/drand/kyber/tree/master)
-
-** Forked repository for use in drand **
+[![Go test](https://github.com/dedis/kyber/actions/workflows/go_tests.yml/badge.svg)](https://github.com/dedis/kyber/actions/workflows/go_tests.yml)
+[![Coverage Status](https://coveralls.io/repos/github/dedis/kyber/badge.svg?branch=master)](https://coveralls.io/github/dedis/kyber?branch=master)
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=dedis_kyber&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=dedis_kyber)
+[![Go Reference](https://pkg.go.dev/badge/github.com/dedis/kyber.svg)](https://pkg.go.dev/github.com/dedis/kyber)
 
 DEDIS Advanced Crypto Library for Go
 ====================================

doc.go

@@ -6,7 +6,7 @@ designed to be independent of specific cryptographic algorithms,
 to facilitate upgrading applications to new cryptographic algorithms
 or switching to alternative algorithms for experimentation purposes.
 
-Abstract Groups
+# Abstract Groups
 
 This toolkits public-key crypto API includes a kyber.Group interface
 supporting a broad class of group-based public-key primitives
@@ -23,9 +23,9 @@ DSA-style integer groups.
 
 As a trivial example, generating a public/private keypair is as simple as:
 
-    suite := suites.MustFind("Ed25519")		// Use the edwards25519-curve
-	a := suite.Scalar().Pick(suite.RandomStream()) // Alice's private key
-	A := suite.Point().Mul(a, nil)          // Alice's public key
+	    suite := suites.MustFind("Ed25519")		// Use the edwards25519-curve
+		a := suite.Scalar().Pick(suite.RandomStream()) // Alice's private key
+		A := suite.Point().Mul(a, nil)          // Alice's public key
 
 The first statement picks a private key (Scalar) from a the suites's source of
 cryptographic random or pseudo-random bits, while the second performs elliptic
@@ -42,7 +42,7 @@ rather than the multiplicative-group terminology of traditional
 integer groups - but the two are semantically equivalent and the
 interface itself works for both elliptic curve and integer groups.
 
-Higher-level Building Blocks
+# Higher-level Building Blocks
 
 Various sub-packages provide several specific
 implementations of these cryptographic interfaces.
@@ -91,7 +91,7 @@ that keep the sources of individual votes or bids private
 without anyone having to trust more than one of the shuffler(s) to shuffle
 votes/bids honestly.
 
-Target Use-cases
+# Target Use-cases
 
 As should be obvious, this library is intended to be used by
 developers who are at least moderately knowledgeable about
@@ -109,7 +109,7 @@ to is the Charm rapid prototyping library for Python
 This library incorporates and/or builds on existing code from a variety of
 sources, as documented in the relevant sub-packages.
 
-Reporting Security Problems
+# Reporting Security Problems
 
 This library is offered as-is, and without a guarantee. It will need an
 independent security review before it should be considered ready for use in
@@ -118,6 +118,5 @@ is YOUR RESPONSIBILITY to arrange for that audit.
 
 If you notice a possible security problem, please report it
 to [email protected].
-
 */
 package kyber

encoding.go

@@ -36,10 +36,10 @@ type Marshaling interface {
 // will have different constraints, of course. Two implementations are
 // available:
 //
-//   1. The protobuf encoding using the variable length Google Protobuf encoding
-//      scheme. The library is available at https://go.dedis.ch/protobuf
-//   2. The fixbuf encoding, a fixed length binary encoding of arbitrary
-//      structures. The library is available at https://go.dedis.ch/fixbuf.
+//  1. The protobuf encoding using the variable length Google Protobuf encoding
+//     scheme. The library is available at https://go.dedis.ch/protobuf
+//  2. The fixbuf encoding, a fixed length binary encoding of arbitrary
+//     structures. The library is available at https://go.dedis.ch/fixbuf.
 type Encoding interface {
 	// Encode and write objects to an io.Writer.
 	Write(w io.Writer, objs ...interface{}) error

encrypt/ecies/ecies_test.go

@@ -5,7 +5,10 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
+	"go.dedis.ch/kyber/v3"
+	"go.dedis.ch/kyber/v3/group/curve25519"
 	"go.dedis.ch/kyber/v3/group/edwards25519"
+	"go.dedis.ch/kyber/v3/group/nist"
 	"go.dedis.ch/kyber/v3/util/random"
 )
 

encrypt/ibe/ibe_test.go

@@ -1,5 +1,6 @@
 package ibe
 
+/*
 import (
 	"encoding/hex"
 	"strings"
@@ -259,3 +260,4 @@ func TestCPAEncryptOnG1(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, msg, msg2)
 }
+*/

examples/bn256_enc_test.go

@@ -5,6 +5,7 @@ import (
 
 	"go.dedis.ch/kyber/v3"
 	"go.dedis.ch/kyber/v3/pairing"
+	"go.dedis.ch/kyber/v3/pairing/bn256"
 	"go.dedis.ch/kyber/v3/util/random"
 )
 
@@ -60,7 +61,7 @@ see for example anon.Encrypt, which encrypts a message for
 one of several possible receivers forming an explicit anonymity set.
 */
 func Example_elGamalEncryption_bn256() {
-	suite := pairing.NewSuiteBn256()
+	suite := bn256.NewSuiteBn256()
 
 	// Create a public/private keypair
 	a := suite.G1().Scalar().Pick(suite.RandomStream()) // Alice's private key