Skip to content

Parameter to configure database connection encryption #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isuldor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Parameter to configure database connection encryption #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/stakepoold/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ var (
defaultDBName = "stakepool"
defaultDBPort = "3306"
defaultDBUser = "stakepool"
defaultDBTLS = "false"
)

// runServiceCommand is only set to a real function on Windows. It is used
Expand Down Expand Up @@ -67,6 +68,7 @@ type config struct {
DBPassword string `long:"dbpassword" description:"Password for database connection"`
DBPort string `long:"dbport" description:"Port for database connection"`
DBName string `long:"dbname" description:"Name of database"`
DBTLS string `long:"dbtls" description:"Use encryption when connecting to database"`
DcrdHost string `long:"dcrdhost" description:"Hostname/IP for dcrd server"`
DcrdUser string `long:"dcrduser" description:"Username for dcrd server"`
DcrdPassword string `long:"dcrdpassword" description:"Password for dcrd server"`
Expand Down Expand Up @@ -260,6 +262,7 @@ func loadConfig() (*config, []string, error) {
DBName: defaultDBName,
DBPort: defaultDBPort,
DBUser: defaultDBUser,
DBTLS: defaultDBTLS,
LogDir: defaultLogDir,
PoolFees: defaultPoolFees,
RPCKey: defaultRPCKeyFile,
Expand Down
2 changes: 1 addition & 1 deletion backend/stakepoold/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ func runMain(ctx context.Context) error {
votingConfig.VoteBits)

var userData = &userdata.UserData{}
userData.DBSetConfig(cfg.DBUser, cfg.DBPassword, cfg.DBHost, cfg.DBPort, cfg.DBName)
userData.DBSetConfig(cfg.DBUser, cfg.DBPassword, cfg.DBHost, cfg.DBPort, cfg.DBName, cfg.DBTLS)

addedLowFeeTicketsMSA, errMySQLFetchAddedLowFeeTickets := userData.MySQLFetchAddedLowFeeTickets()
if errMySQLFetchAddedLowFeeTickets != nil {
Expand Down
8 changes: 5 additions & 3 deletions backend/stakepoold/userdata/userdata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ type DBConfig struct {
DBPassword string
DBPort string
DBUser string
DBTLS string
}

// UserData stores the current snapshot of the user voting config.
Expand Down Expand Up @@ -41,7 +42,7 @@ func (u *UserData) MySQLFetchAddedLowFeeTickets() (map[chainhash.Hash]string, er

tickets := make(map[chainhash.Hash]string)

db, err := sql.Open("mysql", fmt.Sprint(u.DBConfig.DBUser, ":", u.DBConfig.DBPassword, "@(", u.DBConfig.DBHost, ":", u.DBConfig.DBPort, ")/", u.DBConfig.DBName, "?charset=utf8mb4"))
db, err := sql.Open("mysql", fmt.Sprint(u.DBConfig.DBUser, ":", u.DBConfig.DBPassword, "@(", u.DBConfig.DBHost, ":", u.DBConfig.DBPort, ")/", u.DBConfig.DBName, "?charset=utf8mb4&tls=", u.DBConfig.DBTLS))
if err != nil {
log.Errorf("Unable to open db: %v", err)
return tickets, err
Expand Down Expand Up @@ -92,7 +93,7 @@ func (u *UserData) MySQLFetchUserVotingConfig() (map[string]UserVotingConfig, er

userInfo := map[string]UserVotingConfig{}

db, err := sql.Open("mysql", fmt.Sprint(u.DBConfig.DBUser, ":", u.DBConfig.DBPassword, "@(", u.DBConfig.DBHost, ":", u.DBConfig.DBPort, ")/", u.DBConfig.DBName, "?charset=utf8mb4"))
db, err := sql.Open("mysql", fmt.Sprint(u.DBConfig.DBUser, ":", u.DBConfig.DBPassword, "@(", u.DBConfig.DBHost, ":", u.DBConfig.DBPort, ")/", u.DBConfig.DBName, "?charset=utf8mb4&tls=", u.DBConfig.DBTLS))
if err != nil {
log.Errorf("Unable to open db: %v", err)
return userInfo, err
Expand Down Expand Up @@ -131,13 +132,14 @@ func (u *UserData) MySQLFetchUserVotingConfig() (map[string]UserVotingConfig, er
}

// DBSetConfig sets the database configuration.
func (u *UserData) DBSetConfig(DBUser string, DBPassword string, DBHost string, DBPort string, DBName string) {
func (u *UserData) DBSetConfig(DBUser string, DBPassword string, DBHost string, DBPort string, DBName string, DBTLS string) {
dbconfig := &DBConfig{
DBHost: DBHost,
DBName: DBName,
DBPassword: DBPassword,
DBPort: DBPort,
DBUser: DBUser,
DBTLS: DBTLS,
}
u.Lock()
u.DBConfig = dbconfig
Expand Down
2 changes: 2 additions & 0 deletions sample-stakepoold.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ testnet=1
;dbport=3306
;dbname=stakepool
;dbuser=stakepool
; Valid dbtls values are {true, false, skip-verify, preferred}
;dbtls=false

; No default password so you need to specify one.
;dbpassword=
Expand Down