Skip to content

Conversation

@jrick
Copy link
Member

@jrick jrick commented Jan 14, 2026

The truncate option does not exist in this version, so this also removes the ErrTruncateNeeded handling.

The truncate option does not exist in this version, so this also removes the
ErrTruncateNeeded handling.
@jrick
Copy link
Member Author

jrick commented Jan 14, 2026

This probably also requires a major module bump to dcrdex itself, because it uses the badger types in public API, making this a breaking API change.

@JoeGruffins
Copy link
Member

Will get this in asap.

@JoeGruffins
Copy link
Member

JoeGruffins commented Jan 16, 2026

Yeah this appears to break existing databases manifest has unsupported version: 4 (we support 8). Please see https://github.com/dgraph-io/badger/blob/main/docs/troubleshooting.md#i-see-manifest-has-unsupported-version-x-we-support-y-error on how to fix this

@JoeGruffins
Copy link
Member

I guess we just have to write a db update. Would you be able to do this?

@JoeGruffins
Copy link
Member

JoeGruffins commented Jan 19, 2026

I will probably close for #3482 which contains your commit and adds handling for old databases. Just moves them aside, does not attempt an update.

@JoeGruffins
Copy link
Member

Seems to be more problems, figuring them out there.

@jrick
Copy link
Member Author

jrick commented Jan 19, 2026

Seems to be more problems, figuring them out there.

the backup needs to be performed with the older badger code, and the restore done on the new version.

i don't see a great way to automatically handle this unless we import all supported badger versions into the same program (possibly with a phase out so after a certain point, you have to manually migrate if you skip too many versions?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants