eth: Use user set gas limit. #3469
Conversation
JoeGruffins
force-pushed
the
maxgas
branch
2 times, most recently
from
88277ba to
95f0e8a
Compare
|
It's still not using the max gas I set... |
|
I guess I only changed values before the swap actually happens. It is still using the server suggested fee for max gas fee. |
JoeGruffins
force-pushed
the
maxgas
branch
2 times, most recently
from
0b19332 to
3ca4c04
Compare
|
Gas can go over 2000. 
|
JoeGruffins
force-pushed
the
maxgas
branch
3 times, most recently
from
9ed4fe2 to
010c688
Compare
JoeGruffins
force-pushed
the
maxgas
branch
2 times, most recently
from
508bcae to
e508c00
Compare
|
Don't error as much for redeem https://github.com/decred/dcrdex/compare/508bcae2c78208fe85236dfcc8cc746897cb8e72..e508c004820bc460541eb202b72502fe97424ef6 |
JoeGruffins
force-pushed
the
maxgas
branch
2 times, most recently
from
628a21d to
30e58b0
Compare
|
I'm just realizing that core is already asking the node for a fee if not a swap initialization. I think what I'm doing is correct but probably the code can be cleaned up with some things changed in core. Will think about it some more. |
JoeGruffins
force-pushed
the
maxgas
branch
2 times, most recently
from
c1dc204 to
c3d9d66
Compare
|
I think it makes the most sense now. Just ask wallet what the user max is and use that. Error if it's lower than the server. The more important change is actually erroring for all assets if fee at trading time is more than what the max was when the order was made. I don't think it is correct to try and create transactions we expect to fail because of the current fee. |
The user set max fee was only used to compare with the server suggested fee and did not apply to trades. Use the user set max fee when funding starts. Also error in core if current fees are higher than the set max. We should not created swaps that are not expected to be mined.
1 participant
closes #3468, closes #3467, closes #3404
Unsure why we are using the server's max fee regardless atm but maybe there is a good reason. But, it is making trades fail for me on mainnet and I am unable to do anything about it atm.